Add get_mut for fields of spec/runtime #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes youki-dev#165 Signed-off-by: Alex Lyn <[email protected]>
|
Hi @utam0k @saschagrunert Could you please take a look this PR ? Thx |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
- Coverage 22.42% 22.14% -0.28%
==========================================
Files 23 23
Lines 2100 2140 +40
Branches 1157 1167 +10
==========================================
+ Hits 471 474 +3
- Misses 809 843 +34
- Partials 820 823 +3 |
|
@Apokleos It seems CI got the failure. May I ask you to check it? |
This ToString trait is automatically implemented for any type which implements the Display trait. As such, ToString shouldn’t be implemented directly: Display should be implemented instead, and you get the ToString implementation for free. With such fixing, It will make CI with lint-clippy happy. Fixes youki-dev#165 Signed-off-by: Alex Lyn <[email protected]>
|
Hi @utam0k I need your help to execute the CI and help review the code. THX, FYI |
utam0k
approved these changes
May 27, 2024
saschagrunert
approved these changes
May 28, 2024
Apokleos
added a commit
to Apokleos/container-device-interface-rs
that referenced
this pull request
May 30, 2024
In cdi-go, the oci-runtime-tools generate tool is used to generate configuration JSON for the OCI runtime. However, since it is not possible to use existing libraries like cdi-go, we had to implement this functionality ourselves. Additionally, since the pr for oci-spec-rs (youki-dev/oci-spec-rs#166) has been merged but no release version exists yet, we'll utilize the below method for dependency management: oci-spec = { git = "https://github.com/containers/oci-spec-rs.git", rev = "d338cf8", features = ["runtime"] } Signed-off-by: Alex Lyn <[email protected]>
AllexVeldman
added a commit
to AllexVeldman/pyoci
that referenced
this pull request
Sep 13, 2024
With oci-spec 0.6.6 [#166](youki-dev/oci-spec-rs#166) the `to_string()` method started to return the blanket impl of `ToString` due to the `Display` Trait being added. I'm not entirely sure why I got the display trait instead of the `to_string()` implemented on `ImageManifest`, in the rust playground I'm unable to reproduce it. Instead I now call serde_json directly so I don't have to rely on whatever oci-spec implements as the serialization.
AllexVeldman
added a commit
to AllexVeldman/pyoci
that referenced
this pull request
Sep 13, 2024
With oci-spec 0.6.6 [#166](youki-dev/oci-spec-rs#166) the `to_string()` method started to return the blanket impl of `ToString` due to the `Display` Trait being added. I'm not entirely sure why I got the display trait instead of the `to_string()` implemented on `ImageManifest`, in the rust playground I'm unable to reproduce it. Instead I now call serde_json directly so I don't have to rely on whatever oci-spec implements as the serialization.
AllexVeldman
added a commit
to AllexVeldman/pyoci
that referenced
this pull request
Sep 16, 2024
This layer collects and sends traces to the OTLP collector. Trace and Span IDs are now set on Span extensions instead of reusing the tracing generated IDs. fix: oci-spec update outputs pretty manifests With oci-spec 0.6.6 [#166](youki-dev/oci-spec-rs#166) the `to_string()` method started to return the blanket impl of `ToString` due to the `Display` Trait being added. I'm not entirely sure why I got the display trait instead of the `to_string()` implemented on `ImageManifest`, in the rust playground I'm unable to reproduce it. Instead I now call serde_json directly so I don't have to rely on whatever oci-spec implements as the serialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165