Add missing getset to LinuxMemory struct members #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashodhan Joshi <[email protected]>
saschagrunert
approved these changes
Apr 29, 2024
utam0k
approved these changes
May 1, 2024
|
@YJDoc2 Do you want to release oci-spec-rs including this PR? |
Hey, I'd need a release, but I'm still checking some things in the youki to see if any more changes are needed. I'll ping back here once I'm sure current master is enough for release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #155 .
I am working something in Youki which needs to set the memory struct members, for which the setters are missing.
While working on this, I also found that directly getting a
&mut Linuxor&mut LinuxResourseswould be helpful, as otherwise I need to callset_*on each field. I have not implemented theget_mutfunctionality in this, but can add if ok.