Skip to content

Commit

Permalink
Apply comments
Browse files Browse the repository at this point in the history
  • Loading branch information
devleejb committed Feb 2, 2025
1 parent 5fdfdbc commit b1bcdc7
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 5 deletions.
7 changes: 5 additions & 2 deletions backend-go/api/codepair/v1/models/errors.go
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
package models

import "errors"
import (
"errors"
"fmt"
)

func RequiredFieldError(field string) error {
return errors.New(field + " is required")
}

func MinLengthError(field string, min int) error {
return errors.New(field + " must be at least " + string(min) + " characters")
return errors.New(fmt.Sprintf("%s must be at least %d characters", field, min))
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package models
type HttpExceptionResponse struct {

// HTTP status code
StatusCode int32 `json:"statusCode"`
StatusCode int `json:"statusCode"`

// Description of the error
Message string `json:"message"`
Expand Down
1 change: 0 additions & 1 deletion backend-go/internal/core/hello/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ func (h Handler) HelloCodePair(e echo.Context) error {
helloMessage, err := h.helloService.HelloCodePair(e, CodePairVisitor{
Nickname: data.Nickname,
})

if err != nil {
return rest.NewErrorResponse(e, err)
}
Expand Down
1 change: 1 addition & 0 deletions backend-go/internal/core/hello/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,6 @@ func (s Service) HelloCodePair(e echo.Context, codePairVisitor CodePairVisitor)
e.Logger().Fatal(err)
return "", rest.InternalServerError
}

return helloMessage, nil
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"lint:check": "pnpm run --parallel lint:check",
"format": "pnpm run --parallel format",
"format:check": "pnpm run --parallel format:check",
"generate:backend": "openapi-generator-cli generate -i ./api/backend-openapi-spec.json -g go-echo-server -o ./backend-go/api/codepair/v1 --global-property models",
"generate:backend": "openapi-generator-cli generate -i ./api/backend-openapi-spec.json -g go-echo-server -o ./backend-go/api/codepair/v1 --global-property models --type-mappings int32=int",
"generate:frontend": "openapi-generator-cli generate -i ./api/backend-openapi-spec.json -g typescript-axios -o ./frontend/src/api"
},
"devDependencies": {
Expand Down

0 comments on commit b1bcdc7

Please sign in to comment.