Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the current source and destination paths to the replacement function #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tatablack
Copy link

In my use case, I was using the replacement function to manipulate the file text, and I needed to know which file I was editing (full path).

So I exposed the current file path and the current destination path in a way that makes them accessible to the replacement function without having to propagate them all the way down. Let me know if you think this is a suitable solution, or if you'd rather add an additional parameter and propagate it.

I added a note about it in the README.

@yoniholmes
Copy link
Owner

Hey just wanted to say sorry for the delays - have been particularly busy. Still going to be a little while before I can review and merge, there's a queue of pull requests so want to get through these at the same time. Thanks, Jonathan

@tatablack
Copy link
Author

No worries.. by the way, I just noticed this feature is also what #2 is about.
You might still want to implement it differently (passing a single object to the to function with the current parameters as its properties, as you suggested here), though my solution might also be good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants