Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds options to control overwiting behaviors. #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

old9
Copy link

@old9 old9 commented Nov 8, 2013

forceCopy, defaults to true.
forceOverwrite, defaults to false.

forceCopy, defaults to true.
forceOverwrite, defaults to false.

```javascript
replace: {
foceCopy_example: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a typo in the "force" word

@yoniholmes
Copy link
Owner

Hi there. First I wanted to say thanks for taking the time to write this and submit your pull request. Sorry for the delay in getting back to you.

Before I accept it into the main branch I wanted to ask for the following:

  • Can you explain the intended usecase? What do you see as the benefit of forcing the copy to true or false - isn't the final result the same?
  • If the result isn't the same, then it will be necessary to update the test case, to make sure the we automatically test the functionality & don't loose it in the future.

Many thanks again & regards,

Jonathan

@yoniholmes
Copy link
Owner

Hi again,

Sorry there was a mix-up with git issues, so I missed your original answer as for the use case, regarding the watch task. That's fine and a good point. Can you think of a good way to test this? I'd like to make sure all functionality is covered by tests.

Thanks,

Jonathan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants