Fixed balance history bug to allow months with no transactions

yong-space · Nov 29, 2024 · 0133865 · 0133865
1 parent 4b68d11
commit 0133865
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/src/main/java/tech/sledger/endpoints/DashEndpoints.java b/src/main/java/tech/sledger/endpoints/DashEndpoints.java
@@ -29,7 +29,6 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
-import java.util.Optional;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.stream.Collectors;
 
@@ -154,13 +153,10 @@ public ChartResponse getBalanceHistory(Authentication auth) {
         var accountSeries = accountIds.stream().map(accountId -> {
             AtomicInteger monthIndex = new AtomicInteger();
             List<BigDecimal> data = months.stream()
-                .map(month -> {
-                    Optional<MonthlyBalance> value = balanceHistory.stream()
-                        .filter(b -> b.getAccountId() == accountId && b.getMonth().equals(month))
-                        .findFirst();
-                    return value.get();
-                })
-                .map(MonthlyBalance::getBalance)
+                .map(month -> balanceHistory.stream()
+                    .filter(b -> b.getAccountId() == accountId && b.getMonth().equals(month))
+                    .findFirst()
+                    .map(MonthlyBalance::getBalance).orElse(BigDecimal.ZERO))
                 .peek(balance -> {
                     if (summaryData.size() < months.size()) {
                         summaryData.add(balance);