Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README, Settings to include new MeCab installer repo #326

Merged
merged 10 commits into from
Nov 18, 2023
Merged

Update README, Settings to include new MeCab installer repo #326

merged 10 commits into from
Nov 18, 2023

Conversation

koiyakiya
Copy link

In this PR, I added the Advanced Options header in the README, with a subheading of Parse sentences using MeCab. I'm not sure if this is wanted, but it is all I could come up with to reference the updated repo. In addition, I updated the link in ext/settings.html to the new repo.

The repo

(I also added a period at the end of #yomitan-development, since it bugged me...)

Copy link

github-actions bot commented Nov 17, 2023

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@djahandarie
Copy link
Collaborator

Thank you! On second thought it actually would be best to move this repo into TheMoeWay org. I just sent you an invite to be an org member, once you accept that you should be able to move the repo. That way we can ensure the repo stays alive and has the same security controls on it, etc.

@koiyakiya
Copy link
Author

Thank you! On second thought it actually would be best to move this repo into TheMoeWay org. I just sent you an invite to be an org member, once you accept that you should be able to move the repo. That way we can ensure the repo stays alive and has the same security controls on it, etc.

Done. Thanks!
I changed the links to the repository, and this PR should be ready.

@koiyakiya koiyakiya marked this pull request as ready for review November 18, 2023 04:33
@koiyakiya koiyakiya requested a review from a team as a code owner November 18, 2023 04:33
`Show advanced options` -> `Advanced`
@djahandarie djahandarie added this pull request to the merge queue Nov 18, 2023
Merged via the queue into yomidevs:master with commit b113980 Nov 18, 2023
6 checks passed
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants