Fix chromium clipboard access #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on chromium, backend calls to clipboardGet are forwarded to an offscreen script
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
praschke
reviewed
Oct 21, 2023
There was a problem hiding this comment.
besides the comments i left, there are three other issues.
- getImage is not implemented by this change, so Clipboard reading not supported in this context error #269 would not be fixed.
- the contents of the offscreen directory should instead go in the background directory.
- the offscreen permission should be documented in
docs/permissions.md.
implement getImage for offscreen requests move offscreen files, offscreen prep is done in sw prep update permissions document for offscreen rearrange permissions
jbukl
force-pushed
the
offscreen-clipboard
branch
from
bd86f4d to
379fdcf
Compare
djahandarie
approved these changes
Oct 22, 2023
djahandarie
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved from yomichan to this yesterday and was having issues with how I usually mine cards because the clipboard monitor for the search page wasn't working, so I fixed it locally.
Feel free to close this if this is duplicated work or there's a nicer solution in mind.