Add French de-inflection #1668
Open
Add French de-inflection #1668
+3,845
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Salwynn <[email protected]>
Signed-off-by: Salwynn <[email protected]>
Playwright test results
Details
Failed testschromium › visual.spec.js › visual |
jamesmaa
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
I think it's fine to merge as is. We don't currently have many French users but if they run into any issues they can report them to us. Would it be easy to add TODO's to all the missing coverage of grammar or is that too much work? With a file size this large it might better organized that way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to Salwynn's work in #1626
Resolves #1572
I haven't tested the rules thoroughly but I fixed everything I could notice in the transforms.
Let me know if I've overlooked anything.