Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sentence parser works for spaced languages #1624

Closed
wants to merge 2 commits into from

Conversation

khaitruong922
Copy link

Since all terms are trimmed after processed by the parser and the option Show space between parsed words only adds a right margin instead of a space, all words are clumped together so whole word scan will not work.

Although it's not recommended to use sentence parser for spaced languages, some users may have this on. I've fixed to make this at least work by adding a space between the terms. The option Show space between parsed words will be hidden and default to true for spaced languages. The only use case that I find marginally useful is that it makes recognizing terms with more than 1 words easier.

image

For example, we can see that all terms are widely spaced by space character + margin, so come back is easily recognized as a term.

If this is not worth it, then we can consider disable the parser and hide the settings for spaced languages.

@khaitruong922 khaitruong922 requested a review from a team as a code owner November 27, 2024 15:49
Copy link

github-actions bot commented Nov 27, 2024

Playwright test results

passed  4 passed
flaky  1 flaky

Details

stats  5 tests across 4 suites
duration  2 minutes, 38 seconds
commit  3c3f858

Flaky tests

chromium › integration.spec.js › anki add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant