Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1439 pitch accents and pronunciations are grouped by pronunciation #1570

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ganqqwerty
Copy link

…rather than by dictionary. Now every pitch enthusiast can install 800+ dictionaries and the view will still be compact enough. Corresponding ticket is #1439

CleanShot 2024-11-05 at 20 34 01@2x

@MarvNC
Copy link
Member

MarvNC commented Nov 5, 2024

how does it decide what order the pitches are displayed? IIRC the original dictionaries list them in order of frequency. Maybe it could be like frequency dictionaries where it writes the priority each was given?

Copy link

github-actions bot commented Nov 5, 2024

Playwright test results

failed  1 failed
passed  3 passed
flaky  1 flaky

Details

stats  5 tests across 4 suites
duration  5 minutes, 43 seconds
commit  374cc41

Failed tests

chromium › visual.spec.js › visual

Flaky tests

chromium › integration.spec.js › anki add

@ganqqwerty
Copy link
Author

ganqqwerty commented Nov 5, 2024

how does it decide what order the pitches are displayed? IIRC the original dictionaries list them in order of frequency.

right now the order is random. The nomimono is [2][3] in 2 dictionaries, [2] in one and [3][2] in two more dictionaries.

image

Maybe it could be like frequency dictionaries where it writes the priority each was given?

I have hard times visualizing it. Could you give me an example for nomimono?

@ganqqwerty
Copy link
Author

@MarvNC

@ganqqwerty
Copy link
Author

ganqqwerty commented Nov 5, 2024

oh, I think I got it... like it will be のみ\もの [Kanjium Pitch Accents: 2][NHK: 1][大辞泉: 1] . I guess I can preserve this information but I feel that it can create a bit of confusion and visual clutter. When the user hovers over [Kanjium Pitch Accents: 2] the tooltip can appear clarifying that according to Kanjium Pitch Accents dictionary, this pitch is the 2nd most frequent for this word...

Or maybe the order itself can be put into the tooltip...

@MarvNC
Copy link
Member

MarvNC commented Nov 5, 2024

hmm this is getting complicated but i'd average their positions to decide what order they're displayed in, and yeah like that to show the priority in each dict.

@ganqqwerty
Copy link
Author

like this maybe
CleanShot 2024-11-05 at 21 25 02@2x

@MarvNC
Copy link
Member

MarvNC commented Nov 5, 2024

i'd prefer it to not be hidden in a tooltip as it's just one digit; would be curious to hear more thoughts.

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Nov 6, 2024
@ganqqwerty ganqqwerty force-pushed the 1439-multiple-pitch-dictionaries-grouped branch 2 times, most recently from 1d5cc1c to 468ad75 Compare November 14, 2024 21:50
@ganqqwerty ganqqwerty force-pushed the 1439-multiple-pitch-dictionaries-grouped branch from 468ad75 to 979e8eb Compare November 14, 2024 21:58
@jamesmaa
Copy link
Collaborator

jamesmaa commented Dec 5, 2024

i'd prefer it to not be hidden in a tooltip as it's just one digit; would be curious to hear more thoughts.

I feel like ordering it would be just fine? We can always fix it later if users complain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants