-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1439 pitch accents and pronunciations are grouped by pronunciation #1570
base: master
Are you sure you want to change the base?
#1439 pitch accents and pronunciations are grouped by pronunciation #1570
Conversation
how does it decide what order the pitches are displayed? IIRC the original dictionaries list them in order of frequency. Maybe it could be like frequency dictionaries where it writes the priority each was given? |
right now the order is random. The nomimono is [2][3] in 2 dictionaries, [2] in one and [3][2] in two more dictionaries.
I have hard times visualizing it. Could you give me an example for nomimono? |
oh, I think I got it... like it will be のみ\もの [Kanjium Pitch Accents: 2][NHK: 1][大辞泉: 1] . I guess I can preserve this information but I feel that it can create a bit of confusion and visual clutter. When the user hovers over [Kanjium Pitch Accents: 2] the tooltip can appear clarifying that according to Kanjium Pitch Accents dictionary, this pitch is the 2nd most frequent for this word... Or maybe the order itself can be put into the tooltip... |
hmm this is getting complicated but i'd average their positions to decide what order they're displayed in, and yeah like that to show the priority in each dict. |
i'd prefer it to not be hidden in a tooltip as it's just one digit; would be curious to hear more thoughts. |
1d5cc1c
to
468ad75
Compare
468ad75
to
979e8eb
Compare
I feel like ordering it would be just fine? We can always fix it later if users complain |
…rather than by dictionary. Now every pitch enthusiast can install 800+ dictionaries and the view will still be compact enough. Corresponding ticket is #1439