Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring v2 up to date with current changes on master #140

Open
wants to merge 47 commits into
base: v2
Choose a base branch
from

Conversation

joshkopecek
Copy link

@joshkopecek joshkopecek commented Jun 3, 2023

This PR brings the v2 branch up to date with the current changes to y-websocket on master.

I'd love to see this published as an official version, as I need a version that is pure esm.

Huly®: YJS-720

dmonad and others added 30 commits November 20, 2021 15:43
according to the [doc](https://docs.npmjs.com/cli/v8/commands/npx), npx needs package name rather than the binary name. so executing `npx y-websocket-server` would not download and run the server binary in `y-websocket`, it would download from [y-websocket-server](https://npmjs.com/package/y-websocket-server) instead, which could lead to remote arbitrage code execution.
…e because 'process' listens to' exit 'events and uses anonymous functions to contain' this'
Improve the judgment condition of WS connection status in resync
Correct me if I'm wrong, but mutex/mux are no longer being used, right?
remove vestigial mutex code
Added a comment to clarify why reply messages are not sent when their length is 1. Alternatively we could also create a function with a descriptive name of the check being performed,

```js
function hasMessage(encoder) {
    return encoding.length(encoder) > 1;
}
```

The `if` statement would then look something like,

```js
if (hasMessage(encoder)) {
    send(...);
}
```

Thoughts?
Export message type constants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.