Destroy outdated yDocs, ensure persisted doc has loaded#7
Open
Destroy outdated yDocs, ensure persisted doc has loaded#7
Conversation
…g sync, observe memory use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had trouble with memory management using y-websocket-server. The server process was using several GBs of RAM. I found that this was because the server was retaining yDocs in memory, even after the client had closed the connection. Secondly, when using LevelDB as a persistence database, the server was sending a sync message before LevelDB had supplied the document, with the result that empty documents were being served to clients.
This PR (a) includes code that is very careful to destroy YDocs when they are no longer needed (b) allows optional monitoring of memory use (set the environment variable VERBOSE non-zero to log connections and memory use to the console) and (c) awaits the loading of a persisted document before emitting the sync signal (the last relates to event when documents have synced).