Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various fixes for Docker #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

various fixes for Docker #21

wants to merge 3 commits into from

Conversation

beorn
Copy link
Contributor

@beorn beorn commented Apr 29, 2024

  • graceful exit for all servers
  • Dockerfile for blocksuite (same as auth-express)
  • move dependencies from root package.json to demos as appropriate
  • use console.log for logging (didn't seem like print logging system worked and it wasn't used everywhere)
  • output config variables on startup (for tracing/debugging)
  • some renames - but could do more (I like authn for authentication and authz for authorization)
  • using "standard" image for minio container
  • using trust mode for postgres container (doesn't expose a public port, so safe enough for testing)
  • the only thing that needs to be put in your .env is the auth_*_keys

Some questions

  • It would be nice to have a prettierrc setup so code formatting could be used and be consistent with what you use
  • The YAML anchors doesn't work across includes - so ./demos/*/compose.yaml can't get the anchors from ./compse.yaml - perhaps it'd be useful to use Docker configs instead for this
  • Is rollup really needed, at least in the root package.json?
  • I still think it'd be nice to do a monorepo with separate packages - and could then use something like ultra-runner (or turborepo) to run multiple scripts at the same time with colorized log output

beorn added 3 commits April 29, 2024 13:31
- graceful exit for all servers
- Dockerfile for blocksuite (same as auth-express)
- move dependencies from root package.json to demos as appropriate
- use console.log for logging (didn't seem like print logging system worked and it wasn't used everywhere)
- output config variables on startup (for tracing/debugging)
- some renames - but could do more (I like authn for authentication and authz for authorization)
@Loki-Afro
Copy link

@beorn you shouldn't use npm install either, instead use npm ci to make use of the package-lock.json ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants