Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes hardcoded
0
value which assumes that a selection at the beginning of a documentSelection.atStart
has a position of0
. Depending on the document type, a valid selection at the start of the document may begin at a value larger than that (relevant comment: ueberdosis/tiptap#1595 (comment)).Mainly fixes issue of autofocusing editor on mount and on yjs content load: selection is at beginning of document before yjs content load, and is at end of document after yjs load. Expected behavior is that selection stays at beginning of document.
absolutePositionToRelativePosition
might still contain additional bugs because 1. there are otherpos == 0
statements in the function logic 2. unknown whether (initial) selections at end of the documentSelection.atEnd
have problems.