sync-plugin: make y-prosemirror
build against new yjs
.
#144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Currently,
y-prosemirror
does not build againstyjs
newer (or equal) thanv13.5.45
, itnpm run dist
throws:Cause:
In
yjs
, theel.getAttributes(snapshot)
was changed toel.getAttributes()
, (the implementation did not use the snapshot arg anyway) here - if I amgit blaming
correctly :-)yjs/yjs@v13.5.44...v13.5.45#diff-c299d1b6aeba1b81704fa26fd317da05091111fc72ac264c0772d2563ed9f6f8L1237
Fix:
package.json
deps to the lowestyjs
version with the arg removed