Inspect meta of appendedTransaction for possible addToHistory:false
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase if custom plugin issued transaction via `appendTransaction`
… to prevent transaction from appearing on undo stack. fixes yjs#141
romansp
changed the title
appendedTransaction for possible `addToHistory:falseappendedTransaction for possible addToHistory:false
|
Great fix for developers trying to chain multiple commands together but only have one undo / redo for all using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #141.
Using the same approach as in native
prosemirror-history, added inspection ofappendedTransactionmeta for possibleaddToHistory: falseto prevent root transaction from appearing on the undo/redo stack.Added a test case that covers expected behavior.