Use ITextModel.applyEdits to prevent reverts of local changes while remote changes are applied to the model #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lete ops when local ops are applied, which can lead to inconsistent ITextModels on the different clients. Using the ITextModel.applyEdits prevents these ops
…lete ops when local ops are applied, which can lead to inconsistent ITextModels on the different clients. Using the ITextModel.applyEdits prevents these ops
…lete ops when local ops are applied, which can lead to inconsistent ITextModels on the different clients. Using the ITextModel.applyEdits prevents these ops
|
This is great, thank you! Now undoing leads to fragmented documents if another user is also editing the document, but that is much better than having sync issues. When I created this editor binding initially I wanted to keep the native undo manager. Now I think it makes sense to switch to the Yjs UndoManager. I created a separate ticket to track this feature #9. I will merge this PR and publish a new release. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ITextModel.pushEditOperationswill eventually create deleteIModelContentChanges for local changes while remote changes are applied to the model withpushEditOperations. The changes revert the local changes immediately. It is unclear why that is happening. However, applying edits with (although discouraged)ITextModel.applyEditscircumvents these delete ops.