Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added REDIS cache configuration property ("username") in cache config… #4569

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

arfeen
Copy link
Contributor

@arfeen arfeen commented Oct 4, 2024

A new cache configuration property ("username") in cache config for REDIS. Optional field, not needed for REDIS versions do not accept username.

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC?
Tests pass? ✔️
Fixed issues

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcovtwout Please take a look when you have time

As suggested by @rob006, existance "password" value is enough to go for AUTH, if username supplied, it will go with both username and password

Co-authored-by: Robert Korulczyk <[email protected]>
framework/caching/CRedisCache.php Outdated Show resolved Hide resolved
framework/caching/CRedisCache.php Outdated Show resolved Hide resolved
@marcovtwout marcovtwout merged commit 7d8c60e into yiisoft:master Oct 14, 2024
13 checks passed
@marcovtwout
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants