Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test Suricata #1103

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add test Suricata #1103

wants to merge 2 commits into from

Conversation

sebdraven
Copy link
Collaborator

No description provided.

@sebdraven sebdraven requested a review from tomchop July 8, 2024 11:55
@sebdraven sebdraven added the code health Changes about syntax, code health, etc. label Jul 8, 2024
@@ -256,3 +257,14 @@ def test_forensic_artifacts_parent_extraction(self):

self.assertEqual(vertices[artifacts[1].extended_id].name, "Artifact2")
self.assertEqual(vertices[artifacts[2].extended_id].name, "Artifact3")

def test_suricata_rule(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we're doing validation, please add another test where the rule is invalid that asserts creation has failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Changes about syntax, code health, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants