[SQL-261] Reactions tutorial rewrite #428
Open
+174
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvinqian00
commented
Oct 23, 2024
| @@ -117,4 +117,124 @@ java -cp bench.jar lrsql.bench [arguments] | |||
|
|
|||
| Sample insert and query inputs can be found in the distribution at `bench/` | |||
|
|
|||
| ### Reaction JSON | |||
There was a problem hiding this comment.
I'm honestly not sure if this the dev documentation page is best place to put the reactions spec, since it makes it pretty long. Instead would it be a better idea to make a separate page for the spec?
kelvinqian00
commented
Oct 23, 2024
There was a problem hiding this comment.
These screenshots will be replaced with ones from the updated UI once that PR is merged.
kelvinqian00
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Reactions tutorial mainly uses JSON examples, but JSON is mainly used as an internal storage format. This rewrite uses screenshots from the Reactions UI, which the user actually interfaces with, on the Reactions page. Meanwhile, a description of the internal reactions spec (based on the tables used by the xAPI statement and profile specs), along with the JSON example, have been moved to the developer documentation page.