replace ClassyPrelude with RIO in simple #194
Conversation
| ( module RIO | ||
| ) where | ||
|
|
||
| import RIO |
There was a problem hiding this comment.
I wonder if it would be possible to provide a HasLogFunc instance on the App type instead.
There was a problem hiding this comment.
Let me get back to you n that — probably on Friday.
|
I was also pleasantly surprised also by how easily it seemed to converge. So we press on... |
It looks to me as if this template will have to be strictly for early adopters until the deeper conversion of Yesod to RIO has been completed. All the differences are superficial but it looks like there are more than enough of them to confuse without a special guide for the unwary. The major issue is that the handler is just not a RIO so application developers are going to have to apply converters to their RIO based handlers to insert them into Yesod 1.6. The converter I have constructed here is based on the one I have written for my own application is based merely on the `App` foundation, but it should probably be based on `HandlerData`, to give us the (projected) Yesod 1.7 handlers. (I am happy to do this in the next patch if @snoyberg agrees -- I would expect it to be a straightforward generalisation.) The other immediate issue is that, AFAICS, the RIO loggers and monad-logger loggers are incompatible, so the Yesod porcelain will continue to use the latter while RIO handlers would use the former. (Which works for me, but might come across as clunky for others.)
|
@snoyberg I have updated the branch based on your suggestion and a live experiment (in a closed-source context). See the notes on the commit. The TL;DR is that it looks to me like Yesod 1.7 will be needed to get a satisfactory template fit for general developers. The experiment looks like it might be useful however — you are best placed to judge that — and I am happy to continue hacking for as long as you find it useful. |
| @@ -1,3 +1,4 @@ | |||
| /stack.yaml | |||
There was a problem hiding this comment.
This shouldn't be included in a template, we'll want the users of the template to check in their stack.yaml file.
|
|
||
| - rio >= 0.1.8.0 | ||
| - http-types | ||
| - persistent |
There was a problem hiding this comment.
This dependency and the next shouldn't be included in an actual simple template. I'm assuming it's here for testing/instances/etc.
|
I love the idea, and I think Michael does too — it is just a matter of finding the time to get it done. I was hoping we might be able cut some corners but that does not look feasible — we would need to convert the heart of Yesod. The earliest I could look at it would be towards the end of the year but I am pretty sure I would need some help from Michael. |
CF: yesodweb/yesod#1602
CC: @snoyberg
This template takes
simpleand replacesclassy-prelude-*with
rio.Some points:
http-types,yesod-newsfeedandpersistentwas added withno bounds restrictions — what restrictions should we use
on these packages?
rio >= 0.1.8.0: is my starting point — can we relax theupper bound? What upper bound should we use?
rioto work with the current stack I am hiding parts of theriologging system (I guess these will be addressed bythis work).
I am out of time this weekend and I have not had time to build and instantiate the template. I will happily do so later in the week (Friday) if nobody has done so by then.