This repository was archived by the owner on Mar 26, 2018. It is now read-only.
fix bower_component loading problem on _gulpfile template#1408
Open
yohannist wants to merge 1 commit intoyeoman:masterfrom
Open
fix bower_component loading problem on _gulpfile template#1408yohannist wants to merge 1 commit intoyeoman:masterfrom
yohannist wants to merge 1 commit intoyeoman:masterfrom
Conversation
|
no |
Author
|
is the issue fixed?
On Tue, Sep 19, 2017 at 5:13 PM ahakeem ***@***.***> wrote:
no
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1408 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AECguyoLY8BR3ZMV-6e-BuK_u9CyWT4Sks5sj8wKgaJpZM4N0PQP>
.
--
Regards,
Yohannes
|
|
thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
All the packages installed via bower were not automatically inserted into
index.html. The reason iswiredepis not properly configured with the proper path tobower_components.In addition, the server middleware was also not configured to use
bower_componentsso even if users add the script tags to packages inbower_componentsmanually, the server would return404 not foundto the browser requests.A final problem addressed in this pull request is that the
watchtask was not monitoringindex.htmlso the browser was not refreshing when that was changed.The consequence of these problems is when running
gulp serve, the user is met with a page that has nocssand nojslibraries.After:
• Fixed
wiredepdirectory to proper location (outside of the app folder)• Started watching
index.html(via paths.views.main)• Added bower_component as a resource for the server middleware