This repository was archived by the owner on Mar 26, 2018. It is now read-only.
refactor(controller_typescript) use this instead of $scope#1188
Open
ericmdantas wants to merge 1 commit intoyeoman:masterfrom
Open
refactor(controller_typescript) use this instead of $scope#1188ericmdantas wants to merge 1 commit intoyeoman:masterfrom
ericmdantas wants to merge 1 commit intoyeoman:masterfrom
Conversation
Member
|
what does this accomplish? |
Author
|
@eddiemonge it uses the same approach in the non typescript environment, where $scope is not used. |
Member
There was a problem hiding this comment.
shouldn't it be array? not really sure since i havent used TypeScript though
Member
|
Can you update the commit message to follow the contrib guidelines please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.