Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvements #1367

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

minor improvements #1367

wants to merge 2 commits into from

Conversation

Kartofanych
Copy link

No description provided.

@Kartofanych Kartofanych force-pushed the dev branch 5 times, most recently from 523eb9d to 0144ba6 Compare December 13, 2024 12:15
@Kartofanych
Copy link
Author

@yegor256 помоги тут пожалуйста разобраться, почему таски не запускаются?

@yegor256
Copy link
Owner

@Kartofanych maybe some bug in GitHub. Just push some new changes to your branch, this will re-start the jobs.

@yegor256
Copy link
Owner

@Kartofanych
Copy link
Author

@Kartofanych also, read this: https://www.yegor256.com/2015/07/06/public-static-literals.html

here is examples about Public Static Literals but i dont have it - only private constants

@Kartofanych
Copy link
Author

@Kartofanych maybe some bug in GitHub. Just push some new changes to your branch, this will re-start the jobs.

unfortunately, didnt help

@yegor256
Copy link
Owner

@Kartofanych try again please, I upgraded to macos 15

@Kartofanych
Copy link
Author

@Kartofanych try again please, I upgraded to macos 15

some strange issue in yamlint now - in my class there are no extra empty lines, and i didnt touch any other files

@yegor256
Copy link
Owner

@Kartofanych I fixed yaml

@yegor256
Copy link
Owner

@Kartofanych what is the motivation for these changes? I don't think the code became more readable. Instead, it's longer now and harder to read, in my opinion.

@Kartofanych
Copy link
Author

@Kartofanych what is the motivation for these changes? I don't think the code became more readable. Instead, it's longer now and harder to read, in my opinion.

I think now there are no magic numbers and magic characters - every one of them is constant and explained.

@yegor256
Copy link
Owner

@Kartofanych this is not how this repository is designed: we don't use static literals for -1 and other magic numbers. We prefer using numbers, here is why: https://www.yegor256.com/2015/07/06/public-static-literals.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants