Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improvements to the doppelganger model #302

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix: improvements to the doppelganger model #302

merged 1 commit into from
Sep 7, 2023

Conversation

ricardodcpereira
Copy link
Contributor

@ricardodcpereira ricardodcpereira commented Sep 1, 2023 •
edited
Loading

This PR introduces the following improvements to the DoppelGANger model:

  • The pre-processing logic of the numerical measurement columns was updated to include auto-normalization.
  • The TF2 functions were updated to the ones used in the original implementation by the model's authors.
  • The example was updated to use the FCC MBA dataset.

@ricardodcpereira ricardodcpereira force-pushed the fix/doppelganger branch 4 times, most recently from 96e207d to d549f77 Compare September 4, 2023 14:29
@ricardodcpereira ricardodcpereira marked this pull request as ready for review September 5, 2023 15:06
@ricardodcpereira ricardodcpereira merged commit 1279e5e into dev Sep 7, 2023
3 checks passed
@ricardodcpereira ricardodcpereira deleted the fix/doppelganger branch September 7, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarros alexbarros alexbarros approved these changes

@aquemy aquemy Awaiting requested review from aquemy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardodcpereira @alexbarros