-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency requests to >=2.31.0, <2.32 [security] - autoclosed #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
chore(deps): update dependency requests to >=2.31, <2.32 [security]
May 26, 2023
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 26, 2023 06:56
32f8a15
to
1bb8b10
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31, <2.32 [security]
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
May 26, 2023
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 26, 2023 11:19
1bb8b10
to
a59898a
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
chore(deps): update dependency requests to >=2.31, <2.32 [security]
May 28, 2023
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 28, 2023 11:02
a59898a
to
b5e81fa
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31, <2.32 [security]
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
May 28, 2023
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 28, 2023 13:34
b5e81fa
to
1f740b3
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
chore(deps): update dependency requests to >=2.31, <2.32 [security]
May 30, 2023
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 30, 2023 04:09
1f740b3
to
80b5df5
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31, <2.32 [security]
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
May 30, 2023
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 30, 2023 04:16
80b5df5
to
c209023
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
chore(deps): update dependency requests to >=2.31, <2.32 [security]
May 31, 2023
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 31, 2023 09:50
c209023
to
0fab5cf
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31, <2.32 [security]
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
May 31, 2023
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 31, 2023 09:51
0fab5cf
to
f6edbff
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
chore(deps): update dependency requests to >=2.31, <2.32 [security]
May 31, 2023
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 31, 2023 09:59
f6edbff
to
c4f1740
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31, <2.32 [security]
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
May 31, 2023
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 31, 2023 10:01
c4f1740
to
e65e397
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
chore(deps): update dependency requests to >=2.31, <2.32 [security]
Jun 6, 2023
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
June 6, 2023 07:01
e65e397
to
5bbba5b
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31, <2.32 [security]
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
Jun 6, 2023
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
June 6, 2023 07:03
5bbba5b
to
11b52b3
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
chore(deps): update dependency requests to >=2.31, <2.32 [security]
Jun 7, 2023
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
June 7, 2023 09:32
11b52b3
to
a3d0fc8
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31, <2.32 [security]
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
Jun 7, 2023
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
June 7, 2023 09:34
a3d0fc8
to
5186924
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
chore(deps): update dependency requests to >=2.31, <2.32 [security]
Jun 18, 2023
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
June 18, 2023 09:11
5186924
to
11557e5
Compare
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 3, 2024 00:15
bc88a29
to
9f2c9ba
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31, <2.32 [security]
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
May 3, 2024
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
chore(deps): update dependency requests to >=2.31, <2.32 [security]
May 3, 2024
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 3, 2024 18:06
9f2c9ba
to
cfc473f
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31, <2.32 [security]
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
May 3, 2024
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
2 times, most recently
from
May 6, 2024 02:51
952b3a2
to
3dc57f9
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
chore(deps): update dependency requests to >=2.31, <2.32 [security]
May 6, 2024
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 6, 2024 04:03
3dc57f9
to
e946ced
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31, <2.32 [security]
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
May 6, 2024
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 6, 2024 04:03
e946ced
to
831e8ec
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
chore(deps): update dependency requests to >=2.31, <2.32 [security]
May 6, 2024
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 6, 2024 08:23
831e8ec
to
3549d39
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31, <2.32 [security]
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
May 6, 2024
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
chore(deps): update dependency requests to >=2.31, <2.32 [security]
May 7, 2024
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
2 times, most recently
from
May 7, 2024 19:49
ec5846b
to
130c25a
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31, <2.32 [security]
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
May 7, 2024
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
chore(deps): update dependency requests to >=2.31, <2.32 [security]
May 9, 2024
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 9, 2024 11:29
130c25a
to
744be18
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31, <2.32 [security]
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
May 9, 2024
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 9, 2024 13:50
744be18
to
32486a7
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
chore(deps): update dependency requests to >=2.31, <2.32 [security]
May 15, 2024
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 15, 2024 11:32
32486a7
to
3b43c2d
Compare
renovate
bot
force-pushed
the
renovate/pypi-requests-vulnerability
branch
from
May 15, 2024 21:31
3b43c2d
to
b541c93
Compare
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31, <2.32 [security]
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
May 15, 2024
renovate
bot
changed the title
chore(deps): update dependency requests to >=2.31.0, <2.32 [security]
chore(deps): update dependency requests to >=2.31.0, <2.32 [security] - autoclosed
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
>=2.28, <2.31
->>=2.31.0, <2.32
GitHub Vulnerability Alerts
CVE-2023-32681
Impact
Since Requests v2.3.0, Requests has been vulnerable to potentially leaking
Proxy-Authorization
headers to destination servers, specifically during redirects to an HTTPS origin. This is a product of howrebuild_proxies
is used to recompute and reattach theProxy-Authorization
header to requests when redirected. Note this behavior has only been observed to affect proxied requests when credentials are supplied in the URL user information component (e.g.https://username:password@proxy:8080
).Current vulnerable behavior(s):
For HTTP connections sent through the proxy, the proxy will identify the header in the request itself and remove it prior to forwarding to the destination server. However when sent over HTTPS, the
Proxy-Authorization
header must be sent in the CONNECT request as the proxy has no visibility into further tunneled requests. This results in Requests forwarding the header to the destination server unintentionally, allowing a malicious actor to potentially exfiltrate those credentials.The reason this currently works for HTTPS connections in Requests is the
Proxy-Authorization
header is also handled by urllib3 with our usage of the ProxyManager in adapters.py withproxy_manager_for
. This will compute the required proxy headers inproxy_headers
and pass them to the Proxy Manager, avoiding attaching them directly to the Request object. This will be our preferred option going forward for default usage.Patches
Starting in Requests v2.31.0, Requests will no longer attach this header to redirects with an HTTPS destination. This should have no negative impacts on the default behavior of the library as the proxy credentials are already properly being handled by urllib3's ProxyManager.
For users with custom adapters, this may be potentially breaking if you were already working around this behavior. The previous functionality of
rebuild_proxies
doesn't make sense in any case, so we would encourage any users impacted to migrate any handling of Proxy-Authorization directly into their custom adapter.Workarounds
For users who are not able to update Requests immediately, there is one potential workaround.
You may disable redirects by setting
allow_redirects
toFalse
on all calls through Requests top-level APIs. Note that if you're currently relying on redirect behaviors, you will need to capture the 3xx response codes and ensure a new request is made to the redirect destination.Credits
This vulnerability was discovered and disclosed by the following individuals.
Dennis Brinkrolf, Haxolot (https://haxolot.com/)
Tobias Funke, (tobiasfunke93@gmail.com)
Release Notes
psf/requests (requests)
v2.31.0
Compare Source
Security
Versions of Requests between v2.3.0 and v2.30.0 are vulnerable to potential
forwarding of
Proxy-Authorization
headers to destination servers whenfollowing HTTPS redirects.
When proxies are defined with user info (https://user:pass@proxy:8080), Requests
will construct a
Proxy-Authorization
header that is attached to the request toauthenticate with the proxy.
In cases where Requests receives a redirect response, it previously reattached
the
Proxy-Authorization
header incorrectly, resulting in the value beingsent through the tunneled connection to the destination server. Users who rely on
defining their proxy credentials in the URL are strongly encouraged to upgrade
to Requests 2.31.0+ to prevent unintentional leakage and rotate their proxy
credentials once the change has been fully deployed.
Users who do not use a proxy or do not supply their proxy credentials through
the user information portion of their proxy URL are not subject to this
vulnerability.
Full details can be read in our Github Security Advisory
and CVE-2023-32681.
v2.30.0
Compare Source
Dependencies
This may contain minor breaking changes so we advise careful testing and
reviewing https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html
prior to upgrading.
Users who wish to stay on urllib3 1.x can pin to
urllib3<2
.v2.29.0
Compare Source
Improvements
standardization. (#6226)
v2.28.2
Compare Source
Dependencies
Bugfixes
v2.28.1
Compare Source
Improvements
iter_content
with transition toyield from
. (#6170)Dependencies
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.