Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PATEGAN integration [SD-50] #129

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

feat: PATEGAN integration [SD-50] #129

wants to merge 3 commits into from

Conversation

jfsantos-ds
Copy link
Contributor

@jfsantos-ds jfsantos-ds commented Dec 14, 2021

Implements the PATEGAN model in accordance with the original article.

@jfsantos-ds
Copy link
Contributor Author

jfsantos-ds commented Dec 14, 2021

Currently the base structure is refactored from a previous implementation.
Next steps are:

  • validation/revision of the train method logic comparing to the article

@jfsantos-ds jfsantos-ds force-pushed the feat/pategan branch 2 times, most recently from b55b820 to 95bbab0 Compare December 15, 2021 18:11
@jfsantos-ds jfsantos-ds changed the title feat: PATEGAN main implementation feat: PATEGAN integration Dec 21, 2021
@jfsantos-ds jfsantos-ds changed the title feat: PATEGAN integration feat: PATEGAN integration [SD-50] Dec 23, 2021
Copy link
Contributor

@fabclmnt fabclmnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PATEGAN code seems good to go, but please provide an example.
@jfsantos-ds

Remove duplicate test files after renaming

Use BaseModel variables
@jfsantos-ds jfsantos-ds marked this pull request as ready for review April 21, 2022 16:35
@jfsantos-ds
Copy link
Contributor Author

@fabclmnt I believe this should be ready to merge, wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Regular
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants