Feature implementation from commits 572659b..03fb746#1
Open
yashuatla wants to merge 15 commits intofeature-base-1from
Open
Feature implementation from commits 572659b..03fb746#1yashuatla wants to merge 15 commits intofeature-base-1from
yashuatla wants to merge 15 commits intofeature-base-1from
Conversation
This isn't useful for SOPS (see removed comment), and thus only adds unnecessary complexity. Basically un-does hashicorp/vault@b4602fc Signed-off-by: Felix Fontein <felix@fontein.de>
Copied from hashicorp/vault@9510adc. Please note that Vault at that point in history did not change the license yet, so using that commit is fine. Signed-off-by: Felix Fontein <felix@fontein.de>
Copied from hashicorp/vault@ed08e45 Please note that Vault at that point in history did not change the license yet, so using that commit is fine. Signed-off-by: Felix Fontein <felix@fontein.de>
… is zero. Signed-off-by: Felix Fontein <felix@fontein.de>
While writing these comments I noticed that OpenBao added similar comments roughly a year ago: openbao/openbao@a209a05 Signed-off-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Felix Fontein <felix@fontein.de>
Improve Shamir Secret Sharing code
Signed-off-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Felix Fontein <felix@fontein.de>
Update all dependencies
Signed-off-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Felix Fontein <felix@fontein.de>
Run 'gofmt -w' on all .go files
…ent default of always doing that unless disabled. Signed-off-by: Felix Fontein <felix@fontein.de>
Add option to explicitly check for the latest version; deprecate current default of always doing that unless disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Code Optimization and Version Check Enhancement
Overview
This PR includes code optimizations in the Shamir's Secret Sharing algorithm, formatting improvements in test files, and an enhancement to the version check functionality.
Change Types
Affected Modules
vault.goshamir.gosops_test.goversion.go