fix(cli): simplify empty event loop handling #6402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
changed the title
arcanis
reviewed
Jul 19, 2024
| @@ -187,17 +187,12 @@ export async function runExit(argv: Array<string>, {cwd = ppath.cwd(), selfPath, | |||
| const cli = getBaseCli({cwd, pluginConfiguration}); | |||
|
|
|||
| function unexpectedTerminationHandler() { | |||
| Cli.defaultContext.stdout.write(`ERROR: Yarn is terminating due to an unexpected empty event loop.\nPlease report this issue at https://github.com/yarnpkg/berry/issues.`); | |||
| throw new Error(`Yarn is terminating due to an unexpected empty event loop.\nPlease report this issue at https://github.com/yarnpkg/berry/issues`); | |||
There was a problem hiding this comment.
Why does the stacktrace matter? Wouldn't the only useful information be the place the aborted async operation was started (which we can't get anyway)?
There was a problem hiding this comment.
If a user wants to locate the file, other than that it doesn't provide much, it's more to let Node.js do the error handling.
There was a problem hiding this comment.
I'd prefer to keep the output clean; at least something like this, similar to what we do in the catch?
Suggested change
| throw new Error(`Yarn is terminating due to an unexpected empty event loop.\nPlease report this issue at https://github.com/yarnpkg/berry/issues`); | |
| Cli.defaultContext.stdout.write(cli.error(new UsageError(`Yarn is terminating due to an unexpected empty event loop.\nPlease report this issue at https://github.com/yarnpkg/berry/issues`))); | |
| process.exitCode = 1; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The error added in #6399 should have used
throw new Error()so that Node.js can handle the printing and provide a stack trace.How did you fix it?
Use
throw new Error()instead of printing an error ourselves.Checklist