Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle strings the same in cjs, esm, and deno #139

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: handle strings the same in cjs, esm, and deno #139

wants to merge 6 commits into from
+92 −67

Commits on May 1, 2023

  1. chore(ts): small tweaks to make typescript happier 

    - Use trimStart/trimEnd instead of deprecated trimLeft/trimRight
    @isaacs
    isaacs committed May 1, 2023
    Configuration menu
    Copy the full SHA
    3ed58ce View commit details
    Browse the repository at this point in the history

  2. fix: handle strings the same in cjs, esm, and deno 

    This also ports some of the `// istanbul ignore` comments to their
associated `/* c8 ignore start/stop */` equivalents, and
coverage-ignores some value fallbacks that are there for safety but can
never be hit in normal usage.

Fix: yargs#138
    @isaacs
    isaacs committed May 1, 2023
    Configuration menu
    Copy the full SHA
    7a37884 View commit details
    Browse the repository at this point in the history

  3. chore: remove istanbul comments

    @isaacs
    isaacs committed May 1, 2023
    Configuration menu
    Copy the full SHA
    8b61045 View commit details
    Browse the repository at this point in the history

  4. chore: move cjs to mjs so standardx doesn't check it

    @isaacs
    isaacs committed May 1, 2023
    Configuration menu
    Copy the full SHA
    fafee28 View commit details
    Browse the repository at this point in the history

  5. chore(test): update esm test to verify correct behavior 

    Previously, it was verifying *incorrect* behavior.
    @isaacs
    isaacs committed May 1, 2023
    Configuration menu
    Copy the full SHA
    f236663 View commit details
    Browse the repository at this point in the history

  6. chore: fix trailing comma causing lint failure

    @isaacs
    isaacs committed May 1, 2023
    Configuration menu
    Copy the full SHA
    9f97090 View commit details
    Browse the repository at this point in the history