Include "TRUE" string in SerializationHelper::convert_boolean #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still relevant for us. I updated the PR to move the change to the new location of the serialization_helper.rb and created a spec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently testing H2 to MySQL migration. Works fine, except the boolean values are all false when migrating from H2 to MySQL.
The reason is simple. H2 databases write boolean values as strings with capital letters (e.g "TRUE").
Adding the "TRUE" String to the ::convert_boolean method fixes this problem.
Signed-off-by: Jason Franklin [email protected]