Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR, a warning is emitted when compiling libyaml with musl libc:
If the warning is ignored (default behaviour), a program using libyaml starts but crashes because
strdup()
is returning garbage:The solution is to follow
strdup()
's manpage and define_GNU_SOURCE
before includingstring.h
.I guess when using other libc, it fallbacks to another version or maybe
_GNU_SOURCE
is set by default but it certainly uses a validstrdup
.Fixes: 625fcfe ("Refactor internal and external API.")