Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things:
backtrace
unstable feature (which I believe has been stabilized) and the defunctbacktrace
method onError
provide_any
anderror_generic_member_access
be mergedOne thing I think is still missing from my changes to this RFC is a bit more detail about how
<dyn Error>.request_ref
and<dyn Error>.request_value
are implemented in terms of the new private typecore::any::TaggedOption
and modulecore::any::tags
. I think that's appropriate because of the documentation on the reference-level explanation section: https://github.com/rust-lang/rfcs/blob/master/0000-template.md#reference-level-explanation@yaahc I think your offer to sync up and discuss this further would help me flesh this section out, unless you don't think it's necessary to go into any further detail.