Improve custom function handling #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanCrotazGivEnergy
approved these changes
Oct 25, 2025
Numbers > 127 shouldn't be used with Int8Array, so to avoid using negative numbers just use Array<number>. Other functions also seem to use this approach.
nazar-codethink
force-pushed
the
nazar/improve_custom_function
branch
from
5a5be9f to
6137476
Compare
Owner
|
Thanks |
jakedegiovanni
pushed a commit
to GivEnergy/node-modbus-serial
that referenced
this pull request
Nov 24, 2025
* In custom function use Array<number> instead of Int8Array Numbers > 127 shouldn't be used with Int8Array, so to avoid using negative numbers just use Array<number>. Other functions also seem to use this approach. * Custom function: fix docs and types, add a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.