Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22738: Target syntax is not set on the transformation context when the document content is rendered #3774

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

mflorea
Copy link
Member

@mflorea mflorea commented Dec 19, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-22738

Changes

Description

  • Set the target syntax on the transformation context, when displaying the document content, based on the display parameters
  • Fix the URL used by the WYSIWYG editor to convert the HTML

Clarifications

  • I'm worried by the fact that I had to update the HTML Converter URL to remove the outputSyntax=plain. This parameter is used in lots of places in conjunction with the get action, so I'm worried there might be other regressions...

Executed Tests

None

Expected merging strategy

  • Prefers squash: Yes

@mflorea mflorea self-assigned this Dec 19, 2024
@mflorea mflorea requested a review from tmortagne December 19, 2024 14:52
@mflorea mflorea merged commit 4397588 into master Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants