XWIKI-22496: Link dialog option button is not keyboard operable #3714
Conversation
* Updated the HTML of the button * Added this button in the focusList * Removed weird listeners that would come with this focusList
| // The four elements before this button are: display link, page selection *3 | ||
| this.getDialog().addFocusable(this.getElement() , 4); | ||
| // Without this, the keyboard press on this focusable element will trigger the click twice... | ||
| this.getElement().removeAllListeners(); |
There was a problem hiding this comment.
Wouldn't it be safer to remove only the keydown listener that seems to be responsible for the double click? See https://github.com/ckeditor/ckeditor4/blob/82796d03d0ebbe34d48f3b65c6dde27107812a51/plugins/dialog/plugin.js#L709-L713 .
There was a problem hiding this comment.
At first I tried to add an additional listener to catch and stop the specific keydown events that are responsible with the problem (the bit that you linked), however, this relies on the CKEditor event system and classes, so it only created more problems and it wasn't easy to stop propagation.
I thought it wasn't straightforward to get rid of only one event listener without its ID in native javascript.
I'll look further into this solution, thanks for your feedback!
There was a problem hiding this comment.
hmm, indeed there is no simple way to remove only the keydown listener (without having a reference to the listener) https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_dom_element.html#method-removeListener . So I'm fine to keep your current solution to remove all listeners.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22496
Changes
Description
Screenshots & Video
2024-12-05.12-44-14.mp4
Note that there's still issues with the pagepicker mode dropdown, but this PR's goal is not to fix this.
Executed Tests
Successfully built
mvn clean install -f xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins ;mvn clean install -f xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-webjar/and tested manually these changes on a live instance (see video above)Expected merging strategy