XWIKI-22492: Livedata filter options are misread #3700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a bit of semantics on the options * Added a live update region for the state of the `active` option.
* Fixed when navigating with arrows and validating with Enter.
mflorea
requested changes
Dec 18, 2024
...web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/xwiki.selectize.js
Outdated
Show resolved
Hide resolved
...web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/xwiki.selectize.js
Outdated
Show resolved
Hide resolved
...web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/xwiki.selectize.js
Outdated
Show resolved
Hide resolved
...web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/xwiki.selectize.js
Show resolved
Hide resolved
...web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/xwiki.selectize.js
Outdated
Show resolved
Hide resolved
...web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/xwiki.selectize.js
Outdated
Show resolved
Hide resolved
| this.liveRegion.text(""); | ||
| } | ||
| } | ||
| oldSetActiveOption.call(this, option, scroll, animate); |
There was a problem hiding this comment.
Suggested change
| oldSetActiveOption.call(this, option, scroll, animate); | |
| return oldSetActiveOption.call(this, option, ...args); |
There was a problem hiding this comment.
The setActiveOption from selectize.js does not return anything. I updated to use the rest arguments but did not add a return here. I doubt it makes a difference though.
Addressed in 017fe21 👍
There was a problem hiding this comment.
I updated to use the rest arguments but did not add a return here. I doubt it makes a difference though.
It can make a difference if setActiveOption starts returning a value in future versions of Selectize. I find it safer to return whatever the overridden function returns (even if that function doesn't return anything in its current version).
...web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/xwiki.selectize.js
Outdated
Show resolved
Hide resolved
* Fixed function name * Fixed the faulty overridding * Improved comments
* Fixed the faulty overridding * Fixed codestyle * Simplified code
|
Tested manually again after 017fe21 , I did not find regressions that would have sneaked in with the recent fixes. |
mflorea
reviewed
Jan 10, 2025
...web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/xwiki.selectize.js
Outdated
Show resolved
Hide resolved
* Improved stability of the function overriding implementation Co-authored-by: Marius Dumitru Florea <[email protected]>
mflorea
approved these changes
Jan 13, 2025
mflorea
pushed a commit
that referenced
this pull request
Jan 13, 2025
* Added a bit of semantics on the options * Added a live update region for the state of the `active` option. * Fixed when navigating with arrows and validating with Enter. (cherry picked from commit 88e3e7d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22492
Changes
Description
activeoption.Clarifications
blanktext which is repeted with NVDA (idk where it comes from and from what I could see online noone found it out). However, now it's followed by the content of the option. This makes the dropdown useable (even if not perfect), before it was barely usable.Screenshots & Video
This is a test with Orca, the most popular screen reader for Linux. Results are similar to NVDA, but it doesn't read out
blankfor each entry.https://github.com/user-attachments/assets/5927a1bf-6232-4a54-a46c-e4a40f60f388
Executed Tests
Manual tests only, see above. With a search of
.selectizein the code base, no test object seemed broken:https://github.com/search?q=repo%3Axwiki%2Fxwiki-platform%20.selectize&type=code
We only added semantics and attributes, there shouldn't be any selector breaking.
Expected merging strategy