Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'npm run package' in addon-unicode-graphemes #5151

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix 'npm run package' in addon-unicode-graphemes #5151

merged 1 commit into from
Sep 20, 2024

Conversation

PerBothner
Copy link
Contributor

If you cd addons/addon-unicode-graphemes and then do:

npm run package

you get:

ERROR in ../../out/common/services/UnicodeService.js 5:16-47
Module not found: Error: Can't resolve 'vs/base/common/event' in '/home/bothner/Software/xterm.js/out/common/services'

This fixes it.

@Tyriar Tyriar merged commit 4e9233d into xtermjs:master Sep 20, 2024
12 checks passed
@Tyriar Tyriar added this to the 6.0.0 milestone Sep 20, 2024
@PerBothner PerBothner deleted the unicode-graphemes-webpack-fix branch September 20, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PerBothner @Tyriar