Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fft #16

Merged
merged 34 commits into from
Nov 25, 2023
Merged

Fft #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
7b3cbc2
added lfilter
spectre-ns Nov 5, 2023
f55f5ce
Ran pre-commit
spectre-ns Nov 5, 2023
6ed23e3
Fixed env file
spectre-ns Nov 5, 2023
37ea6a7
Improved implementation
spectre-ns Nov 5, 2023
0631517
Ran pre-commit
spectre-ns Nov 5, 2023
b818c96
Updated to reflect PR comments
spectre-ns Nov 7, 2023
6661885
Use size_type
spectre-ns Nov 7, 2023
95c8a4f
Try to fix tests
spectre-ns Nov 7, 2023
720a301
Moved one pad out
spectre-ns Nov 7, 2023
bb91da9
Removed extra pad call
spectre-ns Nov 8, 2023
7d4cb3b
Run pre-commit
spectre-ns Nov 8, 2023
848e984
Added basic fft more work needed
spectre-ns Nov 22, 2023
7d8e250
pre-commit
spectre-ns Nov 22, 2023
ad49d87
Tests passing
spectre-ns Nov 22, 2023
4b45c86
Updated cmake version
spectre-ns Nov 22, 2023
9491d43
Run pre=commit
spectre-ns Nov 22, 2023
c0ad164
Added axis
spectre-ns Nov 22, 2023
0c49dfb
pre-commit
spectre-ns Nov 22, 2023
3dec2ac
Added check for power of 2
spectre-ns Nov 23, 2023
912c73f
Added todo
spectre-ns Nov 23, 2023
b3a640b
pre-commit
spectre-ns Nov 23, 2023
de42758
Added comment
spectre-ns Nov 23, 2023
65674cc
Added power of 2 check
spectre-ns Nov 23, 2023
f44c07d
Added TBB to configuration
spectre-ns Nov 24, 2023
69e37bf
Ran pre-commit
spectre-ns Nov 24, 2023
f86bb36
Added comments
spectre-ns Nov 24, 2023
d4bf3a3
Format again
spectre-ns Nov 24, 2023
e7e70e5
Merge branch 'main' into fft
spectre-ns Nov 24, 2023
8b2ac01
Update ghworkflow.yml
spectre-ns Nov 24, 2023
77783b8
Update fft.hpp
spectre-ns Nov 24, 2023
3cff0e1
Ran pre-commit
spectre-ns Nov 25, 2023
78b3fbd
Run static on pr
spectre-ns Nov 25, 2023
c8e71f7
Merge branch 'main' into fft
spectre-ns Nov 25, 2023
e90f86b
Merge branch 'fft' of https://github.com/spectre-ns/xtensor-signal in…
spectre-ns Nov 25, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/static-analysis.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
name: Static Analysis

on: push
on:
workflow_dispatch:
pull_request:
push:
branches: [master]


jobs:
pre-commit:
Expand Down
20 changes: 10 additions & 10 deletions include/xtensor-signal/fft.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ inline auto fft(E &&e) {
} // namespace detail

/**
* @breif 1D FFT of an Nd array along a specified axis
* @param e an Nd expression to be transformed to the fourier domain
* @param axis the axis along which to perform the 1D FFT
* @return a transformed xarray of the specified precision
*/
* @brief 1D FFT of an Nd array along a specified axis
* @param e an Nd expression to be transformed to the fourier domain
* @param axis the axis along which to perform the 1D FFT
* @return a transformed xarray of the specified precision
*/
template <class E,
typename std::enable_if<
xtl::is_complex<typename std::decay<E>::type::value_type>::value,
Expand All @@ -82,11 +82,11 @@ inline auto fft(E &&e, std::ptrdiff_t axis = -1) {
}

/**
* @breif 1D FFT of an Nd array along a specified axis
* @param e an Nd expression to be transformed to the fourier domain
* @param axis the axis along which to perform the 1D FFT
* @return a transformed xarray of the specified precision
*/
* @breif 1D FFT of an Nd array along a specified axis
* @param e an Nd expression to be transformed to the fourier domain
* @param axis the axis along which to perform the 1D FFT
* @return a transformed xarray of the specified precision
*/
template <class E,
typename std::enable_if<
!xtl::is_complex<typename std::decay<E>::type::value_type>::value,
Expand Down
Loading