Uncomment complex test case #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure either. I just released some GC-related changes (libcxxwrap-julia 0.5.3), maybe that helps. |
|
Thanks @barche. It seems that CxxWrap 0.8.2 has not been released released as a Julia package yet though. |
|
Yes, I had missed the new package release system :) Apparently the release does not resolve PR JuliaInterop/CxxWrap.jl#136 however, so I'm holding off on doing a proper release until that one is resolved. |
It does not appear to have solved the issue. I wonder if |
SylvainCorlay
force-pushed
the
master
branch
22 times, most recently
from
fa19914
to
6591b42
Compare
SylvainCorlay
force-pushed
the
master
branch
16 times, most recently
from
c9a4cae
to
10a2ca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not quite sure why this would fail in the pure C++-driven test while it works in the test case where Julia makes the function call. (https://github.com/SylvainCorlay/Xtensor.jl/blob/master/deps/xtensor-julia-examples/tensors.cpp#L71)
I suspect that this might be related to garbage collection.
cc @barche