[WIP] xt::linalg::kron: support arguments of arbitrary number of dimensions #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsix
changed the title
Before this commit, `xt::linalg::kron` only supports 2D arguments. This commit proposes to add support for argument with any number of dimensions. This change of behavior is coherent with what `numpy.kron` does. The current implementation is a performance step back compared to the previous one. Until a better generic implementation is found, keeping a couple of specialized implementations for the most used scenarios makes sense. Tested with `./test/test_xtensor_blas --gtest_filter=xlinalg.kron*`.
|
I have pushed a revised implementation that has significantly better performances compared to the first one. However, it still is an order of magnitude slower than the original one for the 2D scenario. I intend to spend more time on this to improve things further and hopefully come up with a solution that is general and offers acceptable performances. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit,
xt::linalg::krononly supports 2D arguments. Thiscommit proposes to add support for argument with any number of
dimensions. This change of behavior is coherent with what
numpy.krondoes.
The current implementation is a performance step back compared to the
previous one. Until a better generic implementation is found, keeping a
couple of specialized implementations for the most used scenarios makes
sense.
Tested with
./test/test_xtensor_blas --gtest_filter=xlinalg.kron*.