XEP-0167: Make ssrc attribute unsignedInt instead of generic string #1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'ssrc' is no generic string, but an 32-bit unsigned integer. The XEP text also says: > The <description/> element MAY possess a 'ssrc' attribute that > specifies the 32-bit synchronization source for this media stream, > as defined in RFC 3550 [2]. so I'd argue that the XEP already required 'ssrc' to be a uint32 before.
github-actions
bot
added
the
Needs Council
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'ssrc' is no generic string, but an 32-bit unsigned integer.
The XEP text also says:
so I'd argue that the XEP already required 'ssrc' to be a uint32 before.