Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change faucet limit and default amount #53

Merged
merged 2 commits into from
Apr 17, 2024
Merged

change faucet limit and default amount #53

merged 2 commits into from
Apr 17, 2024

Conversation

jonathanlei
Copy link
Contributor

@jonathanlei jonathanlei commented Apr 16, 2024 •
edited
Loading

Change faucet transaction max amount to 1000, default amount to 100

ckniffen
ckniffen approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@ckniffen ckniffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment that it is in XRP and not drops since there was some confusion.

intelliot
intelliot approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@intelliot intelliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we decided that 100 is an acceptable default. People can still request 1000 if needed. And of course, since there is no/minimal rate limiting, those who really need more can just make multiple requests.

src/config.ts Outdated
Comment on lines 35 to 36
XRP_AMOUNT: "1000",
MAX_AMOUNT: "1000",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
XRP_AMOUNT: "1000",
MAX_AMOUNT: "1000",
// Default amount to disburse, in XRP
XRP_AMOUNT: "100",
// When serving requests for higher amounts, this is the maximum for a single funding tx, in XRP
MAX_AMOUNT: "1000",

@jonathanlei jonathanlei merged commit 39181b3 into master Apr 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intelliot intelliot intelliot approved these changes

@ckniffen ckniffen ckniffen approved these changes

@justinr1234 justinr1234 justinr1234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathanlei @intelliot @ckniffen @justinr1234