Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caspian Migration #48

Merged
merged 15 commits into from
Feb 13, 2024
Merged

Caspian Migration #48

merged 15 commits into from
Feb 13, 2024

Conversation

jonathanlei
Copy link
Contributor

use Caspian API to ingest data instead of BigQuery, and add network ID as a field for usage tracking beyond testnet

JST5000
JST5000 reviewed Sep 6, 2023
View reviewed changes
src/config.ts Outdated Show resolved Hide resolved
JST5000
JST5000 reviewed Sep 6, 2023
View reviewed changes
src/config.ts Show resolved Hide resolved
JST5000
JST5000 reviewed Sep 6, 2023
View reviewed changes
src/routes/accounts.ts Outdated Show resolved Hide resolved
JST5000
JST5000 reviewed Sep 6, 2023
View reviewed changes
src/config.ts Show resolved Hide resolved
JST5000
JST5000 reviewed Sep 6, 2023
View reviewed changes
src/routes/accounts.ts Outdated Show resolved Hide resolved
@JST5000
Copy link
Contributor

JST5000 commented Sep 6, 2023

What did you do to test this PR? (And can you update the CONTRIBUTING.md with steps for how they could test their Caspian integration works?)

@jonathanlei
Copy link
Contributor Author

What did you do to test this PR? (And can you update the CONTRIBUTING.md with steps for how they could test their Caspian integration works?)

I manually tested, and it showed up on Caspian table after a triggered workflow run.
adjusted README.md and CONTRIBUTING.md

JST5000
JST5000 reviewed Sep 7, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
JST5000
JST5000 reviewed Sep 7, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
ckniffen
ckniffen requested changes Sep 7, 2023
View reviewed changes
src/routes/accounts.ts Outdated Show resolved Hide resolved
src/routes/accounts.ts Outdated Show resolved Hide resolved
JST5000
JST5000 reviewed Sep 12, 2023
View reviewed changes
src/logging.ts Outdated Show resolved Hide resolved
JST5000
JST5000 reviewed Sep 12, 2023
View reviewed changes
README.md Show resolved Hide resolved
JST5000
JST5000 reviewed Sep 28, 2023
View reviewed changes
src/logging.ts Outdated Show resolved Hide resolved
JST5000
JST5000 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@JST5000 JST5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the small docs updates

JST5000
JST5000 reviewed Feb 12, 2024
View reviewed changes
src/logging.ts Outdated Show resolved Hide resolved
@jonathanlei jonathanlei merged commit 03f39b9 into master Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JST5000 JST5000 JST5000 approved these changes

@ckniffen ckniffen ckniffen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathanlei @JST5000 @ckniffen