Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boundaries #70

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Fix boundaries #70

merged 5 commits into from
Oct 28, 2024

Conversation

kthyng
Copy link
Contributor

@kthyng kthyng commented Oct 25, 2024

Correction in a few built-in calculations of u/v grid to rho-grid interpolations of u and v velocities (currently speed and _uv2eastnorth). In these cases, we need to fill nans with zeros so that the masked locations in the velocity fields are not fully brought forward into the rho mask but are instead interpolated over. By making them 0, they are calculated into the mask_rho positions by combining them with neighboring cells. If this wasn't done, the fact that they are masked would supersede the neighboring cells and they would be masked in mask_rho. This needs to be done anytime the velocities are moved from their native grids to the rho or other grids to preserve their locations around masked cells.

See explanation in whats new
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.90%. Comparing base (0645c3e) to head (3f04e8b).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
xroms/accessor.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   83.93%   83.90%   -0.03%     
==========================================
  Files          17       17              
  Lines        1898     1901       +3     
==========================================
+ Hits         1593     1595       +2     
- Misses        305      306       +1     
Flag Coverage Δ
unittests 83.90% <80.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kthyng kthyng merged commit c3acdad into xoceanmodel:main Oct 28, 2024
11 checks passed
@kthyng kthyng deleted the fix_boundaries branch October 28, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants