chore: added properties from react-router link component #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauta2912
reviewed
Jul 19, 2024
src/common/app-link/app-link.tsx
Outdated
| @@ -13,41 +13,55 @@ import type { Params, RouteName } from "../../routes/routes"; | |||
| defined in this project. To link outside, use <a></a> tags as usual. | |||
| */ | |||
|
|
|||
| type Route = { | |||
| pathParams?: Params; | |||
There was a problem hiding this comment.
are we intentionally changing spaces to tabs?
There was a problem hiding this comment.
sorry, it was a misconfiguration on my code editor 😭
mimitorres
force-pushed
the
chore-redesign-props-link
branch
from
9005284
to
088be2c
Compare
mimitorres
force-pushed
the
chore-redesign-props-link
branch
from
9c5c44f
to
9e81d6b
Compare
lauta2912
approved these changes
Jul 22, 2024
mlvieras
reviewed
Aug 14, 2024
| // Extract pathParams from the routeName | ||
| type AppLinkProps<R extends RouteName> = { | ||
| type AppLinkProps = { |
There was a problem hiding this comment.
I'm wondering if it makes sense to do something like interface AppLinkProps extends <whatever the Link props type is>
| @@ -13,26 +13,24 @@ import type { Params, RouteName } from "../../routes/routes"; | |||
| defined in this project. To link outside, use <a></a> tags as usual. | |||
| */ | |||
|
|
|||
| type AppRedirectProps<R extends RouteName> = { | |||
| type Route = { | |||
There was a problem hiding this comment.
This type is duplicated, I'd prefer to have it centralized if possible
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket/Card
Description of the change
Screenshot/Execution
N/A
Related PRs
N/A