Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stanalone setup channel ID method for multiple channel ID use cases #109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EagleVee
Copy link

@EagleVee EagleVee commented Jun 7, 2023

PR Title

🔄 Type of change:

  • ✨Feature/chore
  • ♻️ Refactor
  • 🔧 Bugfixes

✏️ Description:

When using @xmartlabs/react-native-line on my project, my client requires that there are separate LINE channels for their separate corporations. So after some time digging in the source code, I found a way to use dynamic channel ID by export the LoginManager.setup method to React Native. I thought that this might be a good feature for the SDK so I created this PR. The coding might be not perfect since this is the first time I try to code on Kotlin and Swift, so recommendations are very appreciated!


🎥 Screen record:

Add a screen record of the execution of your functionality. This way the reviewer can better understand what has been added.


📌 Notes:

  • Need a code review for the convention I used

✔️Tasks:


⚠️ Warnings:

  • If the login method gets called before the configure method, the app will crash

@mirland mirland requested review from mirland and emibotti June 7, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant