protobuf-cpp: fix for MinGW and Clang on Windows #5877
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
Nov 30, 2024
Doekin
force-pushed
the
protobuf-cpp-mingw-clang
branch
from
a38808e to
2893b28
Compare
|
Of note, this breaks protobuf-cpp 3.19.4 with the following error on Windows |
|
Sorry, I didn’t notice. The issue occurs because we |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undefined symbol: __start_pb_defaultswhen compiling with Clang (MinGW) on Windows by undefining PROTOBUF_DESCRIPTOR_WEAK_MESSAGES_ALLOWED. #16844undefined symbol: pthread_setspecificby adding pthread to system link dependencies.