Extension version text on Extensions page #1122

dashaluna · 2016-09-28T08:44:04Z

TODO

Fix Windows Azure icon
Disable Update Now button on Extensions page when no/expired licence. Add note that update needs a valid licence. (NB it might be good to add a note to Plugins WP admin page - to notify user and provide a choice to get a licence). NB: Added separate issue for this: Extensions page: add note for Update Now functionality when license is expired #1130

…tly installed version

codecov-io · 2016-09-28T08:54:50Z

Current coverage is 37.93% (diff: 100%)

Merging #1122 into master will not change coverage

@@             master      #1122   diff @@
==========================================
  Files            31         31          
  Lines          2151       2151          
  Methods         256        256          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            816        816          
  Misses         1335       1335          
  Partials          0          0

Powered by Codecov. Last update e03cf9e...7cee914

willmot · 2016-09-28T08:56:07Z

Thanks @dashaluna, big improvement. Could you drop a screenshot of what it looks like, want to check the new wording feels right in-situ.

dashaluna · 2016-09-28T08:56:37Z

Here is how it looks now:

@willmot styling question:

Is there default WP admin styling class that can be adjusted so that we have more space for plugin version area. So that they are on 2 lines instead of 3? Current styling seems to come from wp-admin/css but I couldn't find style guides for it online?

willmot · 2016-09-28T09:14:31Z

The original design intention of this page was to mimic the design of the add plugins screen in wp-admin (seen here: wp-admin/plugin-install.php?s=query+monitor&tab=search&type=term).

It looks like they no longer even show the version so we could actually just drop that completely from plugins which aren't installed or which don't have an update available.

For extensions which are installed and which need updating, let's replace the installed button with an update button. Something like:

We should also change the titles to <h3 />'s instead of <h4 />'s and remove the CSS height from the icons (so they're not stretched).

willmot · 2016-09-28T09:15:10Z

It would obviously be much nicer if we could have much shorter descriptions as well as the cards are all too long and look messy.

…on statuses to mimic WP plugin card functionality: Update now, Active, Activate, Buy Now

dashaluna · 2016-09-28T13:26:56Z

@willmot I've tried to mimic the WP plugin card functionality button as much as possible. So now we have buttons:

Update Now <= installed & update available
Active <= installed & activated
Activate <= installed
Buy Now <= otherwise

Couple of questions:

WP core differentiate between Activate and Network Activate ref: https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/class-wp-plugin-install-list-table.php#L469.
There are capability checks before displaying plugin management buttons ref https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/class-wp-plugin-install-list-table.php#L451 What's our approach here? Shall we do the same?

dashaluna · 2016-09-28T13:30:53Z

and remove the CSS height from the icons (so they're not stretched).

@willmot I can see that rule in the WP native CSS. The icons don't look stretched for me. Are you viewing on big screen? Not sure how to correctly remove this.

willmot · 2016-09-28T13:44:19Z

Awesome!

WP core differentiate between Activate and Network Activate ref:

I'm not actually sure how the extension page functions when BackUpWordPress is Network Activated, something we should test. In Multisite setups the main backup wp-admin page moves to Network Settings so the Extensions page should too and Extensions should then also be Network Activated, let's leave that for a separate ticket though.

There are capability checks before displaying... What's our approach here? Shall we do the same?

Good catch, we should do the same 👍

willmot · 2016-09-28T13:47:08Z

The icons don't look stretched for me.

It's just the Windows Azure icon:

Should be:

Not sure how to correctly remove this.

You'll need to override in our CSS file with a more specific selector.

willmot · 2016-09-28T13:48:43Z

Could you also start a ticket for simplifying the descriptions. I think we could probably get them all down to a single paragraph or so.

Update
Issue #1123

…ightments

dashaluna · 2016-09-29T10:18:46Z

@willmot is it a good idea to display sale stats per extension similar to WP ratings? Don't know if it's something we can pull out.

…array keys

…date now, Active, Activate, etc)

dashaluna · 2016-09-29T12:00:51Z

@willmot I'm a little bit stuck with Update Now functionality. I've copied over the update URL from WP core, but I'm guessing because extensions aren't in the WP plugins repo that's why it doesn't work. What should be the process/URL of updating a plugin?

dashaluna · 2016-09-29T16:44:48Z

Update on the Update Now functionality :) The update URL works correctly, only when the valid licence has been specified prior.

@willmot should we only show Update Now on the Extension page only with valid licence, as this is how it currently works for the main WP plugin page ref: #1126

willmot · 2016-09-29T16:47:35Z

Yeah good call, we could just add the disabled attribute to the button when the license is invalid.

dashaluna · 2016-10-06T11:41:57Z

@willmot I can't figure out how can I check a license status per extension in the main BWP plugin code. Could you give me a hand with that please?

pdewouters · 2016-10-06T12:50:37Z

I don't think we want to start checking licenses in the main BackUpWordPress plugin

dashaluna · 2016-10-06T13:13:02Z

@pdewouters then there is no way to disable the "Update Now" button if we don't know the license status. And we don't disable it for expired / invalid license when you click the button it says the plugin is up to date, but the button is still displayed. Also, in the case of expired/invalid license we can notify a user and give a choice to purchase it.

dashaluna · 2016-10-07T13:35:56Z

@willmot re Update Now button and license checks - I think we should still investigate it but create a new ticket for it, not to block this one. This one already gone further then the original issue description. The functionality works, it's just ever so slightly unclear when you're trying to update an extension that's expired.

I will fix the Azure logo and we should push this to review & merge for the next release.

Also, apologies for a mammoth PR, I know it's over the original description, but seemed to make sense to bundle up related functionality. I tried to make every commit as atomic as possible, so you could review each commit for related functionality. Apologies about that!

willmot · 2016-10-07T14:17:58Z

Awesome Dasha!

I think we should still investigate it but create a new ticket for it

Agreed 👍

I will fix the Azure logo and we should push this to review & merge for the next release.

Great, I think we should do a release next week, we've a few things done now.

Also, apologies for a mammoth PR, I know it's over the original description

No problem, great to see so much stuff improved!

dashaluna · 2016-10-07T14:19:51Z

re Azure image - fixed. I made sure to increase the canvas size to 512x512 as per other logos. Updated on the main site and old log is deleted

willmot · 2016-10-07T14:19:57Z

admin/extensions.php

 namespace HM\BackUpWordPress;
-
+include_once( ABSPATH . 'wp-admin/includes/plugin.php' );


I assume you're including this because we need access to one of the functions it contains? If so, I think it's best practise to include it just before you use the function and add a docblock comment explaining what it's being included for.

That way future developers will know why it's here and whether it's safe to remove or not.

…nt on its usage

dashaluna · 2016-10-11T16:19:13Z

@willmot ready for review & merge

willmot · 2016-10-12T07:14:39Z

@dashaluna I'm out today but let's try to release tomorrow.

dashaluna added 2 commits September 27, 2016 17:47

Change extension version text for clarity - specify latest and curren…

ca802e4

…tly installed version

Fix escaping for translated strings

9444e1e

dashaluna added the In Progress label Sep 28, 2016

dashaluna added this to the 3.6.3 milestone Sep 28, 2016

dashaluna added the Review & Merge label Sep 28, 2016

dashaluna assigned willmot Sep 28, 2016

dashaluna removed the In Progress label Sep 28, 2016

willmot assigned dashaluna and unassigned willmot Sep 28, 2016

dashaluna added In Progress and removed Review & Merge labels Sep 28, 2016

Removed plugin versions from display (bottom left). Added action butt…

4fa2c8c

…on statuses to mimic WP plugin card functionality: Update now, Active, Activate, Buy Now

Remove new lines between HTML elements, for more concise view. Fix al…

f28ee1c

…ightments

dashaluna added 4 commits September 29, 2016 11:35

Add variables for clarity and concision - instead of typing multiple …

c12a8bc

…array keys

Unify i18n function style

a675364

Add missing i18n for an HTML attribute in Buy Now button

7efb2c9

Add permission checks before displaying action buttons for plugin (Up…

f88b37e

…date now, Active, Activate, etc)

dashaluna added Review & Merge and removed In Progress labels Oct 7, 2016

dashaluna assigned willmot Oct 7, 2016

willmot reviewed Oct 7, 2016

View reviewed changes

dashaluna mentioned this pull request Oct 7, 2016

Extensions page: add note for Update Now functionality when license is expired #1130

Open

4 tasks

Move inclusion of WP file before the code that uses it. Add Doc comme…

7cee914

…nt on its usage

dashaluna removed their assignment Oct 11, 2016

willmot approved these changes Oct 12, 2016

View reviewed changes

willmot merged commit 5f9af61 into master Oct 12, 2016

willmot deleted the 1098-extension-version-text branch October 12, 2016 07:14

katmoody added this to the 3.6.4 milestone Apr 28, 2017

dashaluna unassigned willmot Aug 13, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extension version text on Extensions page #1122

Extension version text on Extensions page #1122

dashaluna commented Sep 28, 2016 •

edited

Loading

codecov-io commented Sep 28, 2016 •

edited

Loading

willmot commented Sep 28, 2016

dashaluna commented Sep 28, 2016 •

edited

Loading

willmot commented Sep 28, 2016

willmot commented Sep 28, 2016

dashaluna commented Sep 28, 2016

dashaluna commented Sep 28, 2016

willmot commented Sep 28, 2016 •

edited

Loading

willmot commented Sep 28, 2016

willmot commented Sep 28, 2016 •

edited by dashaluna

Loading

dashaluna commented Sep 29, 2016

dashaluna commented Sep 29, 2016

dashaluna commented Sep 29, 2016

willmot commented Sep 29, 2016 •

edited by dashaluna

Loading

dashaluna commented Oct 6, 2016

pdewouters commented Oct 6, 2016

dashaluna commented Oct 6, 2016

dashaluna commented Oct 7, 2016

willmot commented Oct 7, 2016

dashaluna commented Oct 7, 2016

willmot Oct 7, 2016

dashaluna Oct 7, 2016

dashaluna commented Oct 11, 2016

willmot commented Oct 12, 2016

		namespace HM\BackUpWordPress;

		include_once( ABSPATH . 'wp-admin/includes/plugin.php' );

Extension version text on Extensions page #1122

Extension version text on Extensions page #1122

Conversation

dashaluna commented Sep 28, 2016 • edited Loading

codecov-io commented Sep 28, 2016 • edited Loading

Current coverage is 37.93% (diff: 100%)

willmot commented Sep 28, 2016

dashaluna commented Sep 28, 2016 • edited Loading

willmot commented Sep 28, 2016

willmot commented Sep 28, 2016

dashaluna commented Sep 28, 2016

dashaluna commented Sep 28, 2016

willmot commented Sep 28, 2016 • edited Loading

willmot commented Sep 28, 2016

willmot commented Sep 28, 2016 • edited by dashaluna Loading

dashaluna commented Sep 29, 2016

dashaluna commented Sep 29, 2016

dashaluna commented Sep 29, 2016

willmot commented Sep 29, 2016 • edited by dashaluna Loading

dashaluna commented Oct 6, 2016

pdewouters commented Oct 6, 2016

dashaluna commented Oct 6, 2016

dashaluna commented Oct 7, 2016

willmot commented Oct 7, 2016

dashaluna commented Oct 7, 2016

willmot Oct 7, 2016

Choose a reason for hiding this comment

dashaluna Oct 7, 2016

Choose a reason for hiding this comment

dashaluna commented Oct 11, 2016

willmot commented Oct 12, 2016

dashaluna commented Sep 28, 2016 •

edited

Loading

codecov-io commented Sep 28, 2016 •

edited

Loading

dashaluna commented Sep 28, 2016 •

edited

Loading

willmot commented Sep 28, 2016 •

edited

Loading

willmot commented Sep 28, 2016 •

edited by dashaluna

Loading

willmot commented Sep 29, 2016 •

edited by dashaluna

Loading